Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #19524: Protect use of HeaderIdGenerator with synchronized. #19884

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fix #19524: Protect use of HeaderIdGenerator with synchronized. #19884

merged 1 commit into from
Mar 5, 2024

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Mar 5, 2024

Hopefully this is the only source of the race condition that we have been observing.

@sjrd
Fix scala#19524: Protect use of HeaderIdGenerator with synchronized.
dc6b3cd 
Hopefully this is the only source of the race condition that we
have been observing.
@sjrd sjrd requested a review from Florian3k March 5, 2024 12:32
@sjrd sjrd enabled auto-merge March 5, 2024 12:37
@sjrd sjrd merged commit beba585 into scala:main Mar 5, 2024
17 checks passed
@sjrd sjrd deleted the fix-scaladoc-race-condition branch March 5, 2024 15:38
@hamzaremmal hamzaremmal mentioned this pull request Mar 8, 2024
Merged
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 2, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 3, 2024
@WojciechMazur
Backport "Fix #19524: Protect use of HeaderIdGenerator with `synchr…
1c11610 
…onized`." to LTS (#20978)

Backports #19884 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@Florian3k Florian3k Awaiting requested review from Florian3k

Assignees

@Florian3k Florian3k

Labels
None yet
Projects
None yet
Milestone
3.4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@sjrd @dwijnand @Kordyjan @Florian3k