Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider all parents when checking access to the children of a sum #19083

Merged
merged 2 commits into from
Nov 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions compiler/src/dotty/tools/dotc/core/SymUtils.scala
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ class SymUtils:
else {
val children = self.children
val companionMirror = self.useCompanionAsSumMirror
val ownerScope = if pre.isInstanceOf[SingletonType] then pre.classSymbol else NoSymbol
val ownerScope = if pre.isInstanceOf[SingletonType] then pre.classSymbols else Nil
def problem(child: Symbol) = {

def accessibleMessage(sym: Symbol): String =
Expand All @@ -191,8 +191,7 @@ class SymUtils:
self.isContainedIn(sym) || sym.is(Module) && isVisibleToParent(sym.owner)
def isVisibleToScope(sym: Symbol): Boolean =
def isReachable: Boolean = ctx.owner.isContainedIn(sym)
def isMemberOfPrefix: Boolean =
ownerScope.exists && inherits(sym, ownerScope)
def isMemberOfPrefix: Boolean = ownerScope.exists(inherits(sym, _))
isReachable || isMemberOfPrefix || sym.is(Module) && isVisibleToScope(sym.owner)
if !isVisibleToParent(sym) then i"to its parent $self"
else if !companionMirror && !isVisibleToScope(sym) then i"to call site ${ctx.owner}"
Expand Down
17 changes: 17 additions & 0 deletions tests/pos/i18918.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@

trait SuperTrait {
sealed trait InnerTrait
case class Foo() extends InnerTrait
}

trait OtherTrait

trait TraitWithSelfType extends SuperTrait { this: OtherTrait =>
summon[deriving.Mirror.Of[Foo]]
summon[deriving.Mirror.Of[InnerTrait]]
}

object Implementation extends TraitWithSelfType, OtherTrait {
summon[deriving.Mirror.Of[Foo]]
summon[deriving.Mirror.Of[InnerTrait]]
}