Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper methods use pointers for fields of type CArray and CStruct #93

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Helper methods use pointers for fields of type CArray and CStruct #93

merged 1 commit into from
Jul 2, 2018

Conversation

kornilova203
Copy link
Member

Closes #91

jonas
jonas reviewed Jul 2, 2018
View reviewed changes
Copy link
Member

@jonas jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be documented either under limitations or in a new section.

@kornilova203
Copy link
Member Author

We need proper documentation for helper methods too,
I think about actually using Paradox and documenting everything there

@kornilova203 kornilova203 merged commit fb3c4de into master Jul 2, 2018
@kornilova203 kornilova203 deleted the helpers-for-struct-and-array-fields branch July 2, 2018 09:29
@jonas
Copy link
Member

jonas commented Jul 2, 2018

Yes, I agree.

@kornilova203 kornilova203 mentioned this pull request Jul 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas jonas jonas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kornilova203 @jonas