Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate extern variable declarations #80

Merged
merged 2 commits into from
Jun 29, 2018
Merged

Conversation

jonas
Copy link
Member

@jonas jonas commented Jun 28, 2018

Due to scala-native/scala-native#202 it is not possible to use var so
for now vals are used although not semantically correct.

References #70

Due to scala-native/scala-native#202 it is not possible to use `var` so
for now `val`s are used although not semantically correct.

References #70
@jonas jonas force-pushed the extern-variables branch from 62292ad to d67c129 Compare June 28, 2018 19:42
Copy link
Member

@kornilova203 kornilova203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kornilova203 kornilova203 merged commit c1c1852 into master Jun 29, 2018
@kornilova203 kornilova203 deleted the extern-variables branch June 29, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants