zkSyncEra Testnet config

[moltam89]

Description

Configuration for deploying on zkSyncTestnet.
According to the zkSync docs, hardhat-deploy version ^0.11.26 supports deployments on zkSync Era.

Therefore I've upgraded hardhat-deploy to 0.11.26.
Also, zkSync uses their own "hardhat-zksync-solc" compiler, which has to be imported in hardhat.config.ts.

After these changes, I could deploy to zkSyncTestnet with yarn deploy --network zkSyncTestnet and I could interact with the demo YourContract when I switched the targetNetwork to chains.zkSyncTestnet in scaffold.config.ts.

Let me know if you have any questions.

Best,
Tamas

Additional Information

• I have read the contributing docs (if this is your first contribution)
• This is not a duplicate of any existing pull request

Related Issues

#256

Your ENS/address: monyo.eth

[carletex]

Hey @moltam89

Thanks for this. I left a few comments/questions.

Also...does the deploy script work as it is?

The docs say that you need to use the Deployer from
import { Deployer } from "@matterlabs/hardhat-zksync-deploy";

[moltam89]

Hey @carletex

Also...does the deploy script work as it is?

I could deploy by yarn deploy --network zkSyncTestnet. Not sure if this is the proper answer, or you meant something else.

The docs say that you need to use the Deployer from
import { Deployer } from "@matterlabs/hardhat-zksync-deploy";

I think this would be only needed if we didn't use hardhat-deploy.
If we would import it, we could also deploy by "yarn hardhat deploy-zksync", but it would be different than how other networks are used.

[damianmarti]

Thanks @moltam89

I added the zkSync mainnet config and I was able to deploy the contract to this network using yarn deploy --network zkSync

https://explorer.zksync.io/tx/0x041947bfa70bea288655ce64f4438114f69050f27b2eeafef5f895eb6b26d572

[damianmarti]

Thanks @moltam89

I added the zkSync mainnet config and I was able to deploy the contract to this network using yarn deploy --network zkSync

https://explorer.zksync.io/tx/0x041947bfa70bea288655ce64f4438114f69050f27b2eeafef5f895eb6b26d572

And then I was able to set a new greeting from the debug page.

[moltam89]

Hey @damianmarti ,

Great, thank you for testing this!

[technophile-04]

Tested it and works properly, Tysm @moltam89 looks a lot cleaner 🙌

I have added hardhat-zksync-verify at 3d3ceab...Reason: We already had hardhat-etherscan to which its goes in conjuction and it didn't required any API keys so thought its worth the verify feature by default

Here is the verified contract: https://goerli.explorer.zksync.io/address/0xC8796A82A7A03A333295938d54d8F7310d607be2#contract

PS: I tried deploying to sepolia yarn deploy --network sepolia and got some error the first time but after a second try it worked correctly, just can anyone just test once deploying to sepolia.

[carletex]

My only concern about this PR is how many libraries it adds to yarn.lock. It seems like hardhat-zksync-solc adds @nomiclabs/hardhat-docker as a dependency. I'm not sure why this requires this dependency...

Yep, I think this was also one of the reasons Shiv closed the initial PR. We can't automatically add every single thing that could be useful on SE-2... we'd end with a massive project. That's why he suggested adding it as an extension in the CLI (#251)

In this particular case... I think ZkSyncEra is probably something that will be used and might be worth it to add it to the core.

Let me know what you all think!

[technophile-04]

Yep, I think this was also one of the reasons Shiv closed the initial PR. We can't automatically add every single thing that could be useful on SE-2... we'd end with a massive project. That's why he suggested adding it as an extension in the CLI (#251)

Yes !! I was even not going to suggest creating a PR to main at all and instead have it on just another branch until CLI but then I saw a couple of builds from BG member which was deployed to ZkSync so thought it might be worth the add to main

In this particular case... I think ZkSyncEra is probably something that will be used and might be worth it to add it to the core.

Yup

[damianmarti]

@moltam89 @carletex There is another issue. If you want to replicate all the zkSync features (like a Paymaster) locally, you have to run a local zkSync node, which is not the same that running yarn chain. Maybe it's something we should add a note somewhere at least... https://era.zksync.io/docs/tools/hardhat/testing.html

[damianmarti]

Thanks @moltam89!! Merged!

[moltam89]

Hi @technophile-04

I have added hardhat-zksync-verify at 3d3ceab...Reason: We already had hardhat-etherscan to which its goes in conjuction and it didn't required any API keys so thought its worth the verify feature by default

I tried to verify with yarn verify --network zkSyncTestnet, but I run into this error:
Network with chainId: 280 not supported. You can specify the url manually via --api-url .

How did you run the contract verification?

Thanks,
Tamas