Introduce possibility to use different renderers #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a pretty big change. I'm ok with it, but can I make you a committer in case we have to maintain it going forward? |
|
It mostly refactoring but it does introduce a few new mechanisms indeed. |
eed3si9n
added a commit
that referenced
this pull request
Jul 9, 2015
Introduce possibility to use different renderers
|
Merged, and welcome to the team :) |
|
Thanks :) |
|
BTW, when you're going to cut a new release, do not hesitate to ping me here or on Twitter so that I can update the README to document that feature ;) |
|
I was gonna ask if you want to hand merge all the PRs you just broke :) |
|
I'm currently looking at #58 |
|
I'll take #61 ! |
|
Shall I merge them all ? |
|
Working on #65 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, sbt-buildinfo only allows to write the build info in the form of a Scala class.
It could, however, be interesting to allow to dump the build in another format, e.g. JSON.
This PR introduces
BuildInfoRenderer(along with a few other data types), a trait which allows just that.The current logic for the creation of the Scala class is moved to a dedicated class,
ScalaClassRendererand retrofitted to implementBuildInfoRenderer, set as the default renderer.Existing users of sbt-buildinfo won't be affected by this PR, as the existing model or no pre existing key, only a new key is introduced to specify the renderer to use.