Package, publish and unpack avro schema artifact #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
commented
Apr 14, 2020
RustedBones
commented
Apr 16, 2020
Extract avro schema from any desired dependency
|
Adding the |
RustedBones
commented
Apr 30, 2020
src/main/scala/sbtavro/SbtAvro.scala
Outdated
| inStyle = FilesInfo.lastModified, | ||
| outStyle = FilesInfo.exists | ||
| ) { deps => | ||
| val moduleTarget = extractTarget / module.organization / module.name |
There was a problem hiding this comment.
This is a trade-off: Unpack on separate directories to avoid file name conflict between deps and fail avro generation in case avroUseNamespace is set. Or unpack all schemas in extractTarget but risk conflict
|
Sorry I had to merge #23 first for another fix, which includes the |
|
@nevillelyh Can this have another look before merge ? |
nevillelyh
approved these changes
Jun 18, 2020
nevillelyh
added a commit
that referenced
this pull request
Jun 18, 2020
* Package, publish and unpack avro schema artifact * Update README * Fix caching and use separate target directory * Introduce avroDependencyIncludeFilter setting Extract avro schema from any desired dependency * Use target setting * Unpack avro sources dependencies in sourceManaged folder Co-authored-by: Neville Li <neville@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to package avro sources, publish and declare it as dependency.
To be worked on: In the future, it would be nice to also the support of artifacts withoutavroclassifier as dependencies for the avroGenerate task