Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tokio-rustls to [dev-dependencies] #179

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

cuviper
Copy link
Contributor

@cuviper cuviper commented Feb 11, 2025

This was added to [dependencies] in #178, but I assume that was an accident because it's only used in tests.

This was added to `[dependencies]` in sbstp#178, but I assume that was an
accident because it's only used in tests.
@sbstp
Copy link
Owner

sbstp commented Feb 12, 2025

Thank you, indeed it was not meant to be in the normal dependencies. I will do a new release with this.

@sbstp sbstp merged commit c622bf8 into sbstp:master Feb 12, 2025
4 checks passed
@cuviper
Copy link
Contributor Author

cuviper commented Feb 12, 2025

Thanks for the quick update!

@sbstp
Copy link
Owner

sbstp commented Feb 12, 2025

How did you notice the issue? It might be relevant to setup something to guard this from happening in the future.

@cuviper
Copy link
Contributor Author

cuviper commented Feb 12, 2025

I was checking cargo update -n (dry-run) on a project and noticed it wanted to add a lot of new dependencies. Then I tried my existing dependencies one by one until I saw that it was the attohttpc update pulling more in.

You could use cargo udeps as a safeguard, e.g.:

$ cargo +nightly udeps
    Checking attohttpc v0.28.4 (/home/jistone/rust/attohttpc)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.16s
info: Loading depinfo from "/home/jistone/rust/attohttpc/target/debug/deps/attohttpc-f7d55cb4a897d4d2.d"
unused dependencies:
`attohttpc v0.28.4 (/home/jistone/rust/attohttpc)`
└─── dependencies
     └─── "tokio-rustls"
Note: These dependencies might be used by other targets.
      To find dependencies that are not used by any target, enable `--all-targets`.
Note: They might be false-positive.
      For example, `cargo-udeps` cannot detect usage of crates that are only used in doc-tests.
      To ignore some dependencies, write `package.metadata.cargo-udeps.ignore` in Cargo.toml.

... and 0.28.5 is clean.

@sbstp
Copy link
Owner

sbstp commented Feb 13, 2025

Awesome thanks, I'll add a CI step with udeps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants