Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get more understandable error message on deep structure #24

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

sbrunner
Copy link
Owner

@sbrunner sbrunner commented Jun 3, 2021

No description provided.

@sbrunner sbrunner added the backport master Backport the pull request to the 'master' branch label Jun 3, 2021
@sbrunner sbrunner requested a review from ger-benjamin June 3, 2021 07:36
@sbrunner sbrunner changed the title Get more understandable error message Get more understandable error message on deep structure Jun 3, 2021

return sorted([format_error(e) for e in validator.iter_errors(data)]), data
if error.context:
result = []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small things, but results would be better (with a s at the end)
Same at line 133

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks

},
},
},
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange indentation no ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it's correct, It's done by Black...

@sbrunner sbrunner merged commit c9e101d into 0.9 Jun 4, 2021
@sbrunner sbrunner deleted the better-message branch June 4, 2021 06:55
sbrunner added a commit that referenced this pull request Jun 7, 2021
Get more understandable error message on deep structure
@sbrunner sbrunner added the enhancement New feature label Aug 16, 2022
@c2c-bot-gis-ci
Copy link
Collaborator

Error on backporting to branch master, see Docker Hub actions for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport master Backport the pull request to the 'master' branch enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants