Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

rem_vertex! bugfix #125

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

rem_vertex! bugfix #125

wants to merge 2 commits into from

Conversation

jarbus
Copy link

@jarbus jarbus commented Oct 1, 2021

Resolves an issue where properties that point from the last node to the last node don't get updated with the new vertex number, referenced in #87

The current version of MetaGraphs.jl fails with the following example:

using LightGraphs, MetaGraphs
g = MetaDiGraph(2)
add_edge!(g, 2, 2)
rem_vertex!(g, 1)

Yields

ERROR: LoadError: KeyError: key 1 not found
Stacktrace:
 [1] getindex
   @ ./dict.jl:482 [inlined]
 [2] rem_vertex!(g::MetaDiGraph{Int64, Float64}, v::Int64)
   @ MetaGraphs ~/.julia/packages/MetaGraphs/UlMik/src/MetaGraphs.jl:184

Resolves an issue where properties that point from the last node to the last node don't get updated with the new vertex number
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #125 (4af220c) into master (3a8b98c) will decrease coverage by 1.04%.
The diff coverage is 33.33%.

❗ Current head 4af220c differs from pull request most recent head eda4421. Consider uploading reports for the commit eda4421 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   98.64%   97.60%   -1.05%     
==========================================
  Files           5        5              
  Lines         370      376       +6     
==========================================
+ Hits          365      367       +2     
- Misses          5        9       +4     
Impacted Files Coverage Δ
src/MetaGraphs.jl 97.84% <33.33%> (-1.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8b98c...eda4421. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant