-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support emby branding #504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swap out jellyfin branding for emby when USE_EMBY is enabled.
truecharts-admin
referenced
this pull request
in truecharts/public
Apr 23, 2024
….0@9c5d999 by renovate (#21201) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/sbondco/watcharr](https://togithub.com/sbondCo/Watcharr) | minor | `v1.38.2` -> `v1.39.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>sbondCo/Watcharr (ghcr.io/sbondco/watcharr)</summary> ### [`v1.39.0`](https://togithub.com/sbondCo/Watcharr/releases/tag/v1.39.0) [Compare Source](https://togithub.com/sbondCo/Watcharr/compare/v1.38.2...v1.39.0) #### 🧠 New - Support pinning watched list items to the top of your list (pinned items are highlighted with a gold outline) by [@​IRHM](https://togithub.com/IRHM) in [https://github.com/sbondCo/Watcharr/pull/498](https://togithub.com/sbondCo/Watcharr/pull/498) ![image](https://togithub.com/sbondCo/Watcharr/assets/37304121/005eb3c4-ea90-428b-8687-91bb729a85a8) - Support emby branding (new `USE_EMBY` setting that will swap out Jellyfin branding for Embys branding, no auth logic has been changed) by [@​IRHM](https://togithub.com/IRHM) in [https://github.com/sbondCo/Watcharr/pull/504](https://togithub.com/sbondCo/Watcharr/pull/504) #### 💯 Changed - Better thoughts (now a modal is opened so you can add your thoughts more easily) by [@​IRHM](https://togithub.com/IRHM) in [https://github.com/sbondCo/Watcharr/pull/495](https://togithub.com/sbondCo/Watcharr/pull/495) - Improve search (add content type filters and remove dumb sort) by [@​IRHM](https://togithub.com/IRHM) in [https://github.com/sbondCo/Watcharr/pull/496](https://togithub.com/sbondCo/Watcharr/pull/496) ![image](https://togithub.com/sbondCo/Watcharr/assets/37304121/6c6a846d-da1e-4061-a2b0-e7839fd87176) - Support detailed view for posters on search page by [@​IRHM](https://togithub.com/IRHM) in [https://github.com/sbondCo/Watcharr/pull/497](https://togithub.com/sbondCo/Watcharr/pull/497) #### 🏗️ Fixed - LastFinished Sort: Prefer custom dates that are set on `FINISHED` activities by [@​IRHM](https://togithub.com/IRHM) in [https://github.com/sbondCo/Watcharr/pull/494](https://togithub.com/sbondCo/Watcharr/pull/494) - Content Pages: Make btns container wrap elements when overflowing by [@​IRHM](https://togithub.com/IRHM) in [https://github.com/sbondCo/Watcharr/pull/499](https://togithub.com/sbondCo/Watcharr/pull/499) #### 🥇 Credit A big thanks to [@​n00b12345](https://togithub.com/n00b12345), [@​simonbcn](https://togithub.com/simonbcn), [@​mommyune](https://togithub.com/mommyune), [@​gardebreak](https://togithub.com/gardebreak) and [@​rguinn829](https://togithub.com/rguinn829) for suggesting the improvements/fixes made in this release! #### 🆘 Getting Help If you need help, encounter an issue or find a bug please [create an issue](https://togithub.com/sbondCo/Watcharr/issues/new/choose) or [join our space on Matrix](https://matrix.to/#/#watcharr:matrix.org) for support. Always happy to help! **Package**: https://github.com/orgs/sbondCo/packages/container/watcharr/207084376?tag=v1.39.0 or [on docker hub](https://hub.docker.com/layers/sbondco/watcharr/v1.39.0/images/sha256-9c5d999d92d3475b6a91317727d1620f14b5d85309a3878604f38c60eee22526?context=explore) **Full Changelog**: sbondCo/Watcharr@v1.38.2...v1.39.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTkuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMxOS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
Swap out jellyfin branding for emby when USE_EMBY is enabled.
If someone logs in with Emby, that branding will stay until they relog (assuming use emby is toggled off after they login).
Haven't changed admin ui, users will still show up as jellyfin users, I'm ok manipulating users into thinking we fully support Emby, but might not be a good idea to show the Emby icon over users in admin dash, just incase we do anything in the future around emby support and to avoid confusion of the actual data in db.
Closes #500