Config: Don't omit SIGNUP_ENABLED when empty #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was being removed from config when set to false, then once the server restarts would be set back to default value (true). Now is kept in config with value of false when turned off.
truecharts-admin
referenced
this pull request
in truecharts/public
Mar 12, 2024
….2@bf9adb6 by renovate (#19104) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/sbondco/watcharr](https://togithub.com/sbondCo/Watcharr) | minor | `v1.34.0` -> `v1.35.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>sbondCo/Watcharr (ghcr.io/sbondco/watcharr)</summary> ### [`v1.35.2`](https://togithub.com/sbondCo/Watcharr/releases/tag/v1.35.2) [Compare Source](https://togithub.com/sbondCo/Watcharr/compare/v1.35.1...v1.35.2) #### Fixed - `Registering Disabled` bug when setting up first user [#​400](https://togithub.com/sbondCo/Watcharr/issues/400) If you were affected by this bug, please remove your `watcharr.json` config file, update to this version and try again (alternatively, you could update your `watcharr.json` config and set `SIGNUP_ENABLED` to `true` then restart). Sorry for any inconvenience. #### 🥇 Credit - Thanks to [@​priyajit4u](https://togithub.com/priyajit4u) for reporting the issue fixed in this release. **Package**: https://github.com/orgs/sbondCo/packages/container/watcharr/188028779?tag=v1.35.2 **Full Changelog**: sbondCo/Watcharr@v1.35.1...v1.35.2 ### [`v1.35.1`](https://togithub.com/sbondCo/Watcharr/releases/tag/v1.35.1) [Compare Source](https://togithub.com/sbondCo/Watcharr/compare/v1.35.0...v1.35.1) #### Fixed - Don't omit `SIGNUP_ENABLED` from config when false (fixing it being re-enabled after a restart) by [@​IRHM](https://togithub.com/IRHM) in [https://github.com/sbondCo/Watcharr/pull/399](https://togithub.com/sbondCo/Watcharr/pull/399) #### Documentation - Add `restart` property to docker-compose example by [@​IRHM](https://togithub.com/IRHM) in [https://github.com/sbondCo/Watcharr/pull/398](https://togithub.com/sbondCo/Watcharr/pull/398) #### 🥇 Credit - Thanks to [@​n00b12345](https://togithub.com/n00b12345) for suggesting/reporting the two changes made in this patch release. **Package**: https://github.com/orgs/sbondCo/packages/container/watcharr/187807718?tag=v1.35.1 **Full Changelog**: sbondCo/Watcharr@v1.35.0...v1.35.1 ### [`v1.35.0`](https://togithub.com/sbondCo/Watcharr/releases/tag/v1.35.0) [Compare Source](https://togithub.com/sbondCo/Watcharr/compare/v1.34.0...v1.35.0) #### New - Editing activity time and (soft) deleting activity by [@​stephaje](https://togithub.com/stephaje) in [https://github.com/sbondCo/Watcharr/pull/366](https://togithub.com/sbondCo/Watcharr/pull/366)  - Jellyfin (Manual) Sync (for jellyfin profile, triggered by button in profile page) by [@​IRHM](https://togithub.com/IRHM) in [https://github.com/sbondCo/Watcharr/pull/394](https://togithub.com/sbondCo/Watcharr/pull/394) & [https://github.com/sbondCo/Watcharr/pull/395](https://togithub.com/sbondCo/Watcharr/pull/395) #### Maintenance - ui: bump vite from 5.0.12 to 5.1.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/sbondCo/Watcharr/pull/369](https://togithub.com/sbondCo/Watcharr/pull/369) - ui: bump [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 6.21.0 to 7.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/sbondCo/Watcharr/pull/367](https://togithub.com/sbondCo/Watcharr/pull/367) - ui: bump prettier-plugin-svelte from 3.1.2 to 3.2.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/sbondCo/Watcharr/pull/368](https://togithub.com/sbondCo/Watcharr/pull/368) - ui: bump svelte-check from 3.6.3 to 3.6.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/sbondCo/Watcharr/pull/370](https://togithub.com/sbondCo/Watcharr/pull/370) #### New Contributors - [@​stephaje](https://togithub.com/stephaje) made their first contribution (thanks a lot!) in [https://github.com/sbondCo/Watcharr/pull/366](https://togithub.com/sbondCo/Watcharr/pull/366) **Package**: https://github.com/orgs/sbondCo/packages/container/watcharr/187219192?tag=v1.35.0 **Full Changelog**: sbondCo/Watcharr@v1.34.0...v1.35.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjIzNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
SIGNUP_ENABLED was being removed from config when set to false, then once the server restarts would be set back to default value (true).
Now it is kept in config with value of false when turned off.
Fixes #388