Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add go-retryablehttp #52

Merged
merged 2 commits into from
Jun 23, 2021
Merged

feat: Add go-retryablehttp #52

merged 2 commits into from
Jun 23, 2021

Conversation

sbecker59
Copy link
Owner

Change of solution for the management of rate limiting

  • Adding internal/go-retryablehttp based on hashicorp/go-retryablehttp
  • Removed time.Sleep which allowed to avoid statuscode 420 returns during testing
  • Removed golang.org/x/time/rate which allowed to time out requests

Change of solution for the management error

  • Support for Diagnostics

@sbecker59 sbecker59 linked an issue Jun 13, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #52 (ed52b15) into main (0d13371) will decrease coverage by 2.11%.
The diff coverage is 77.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   84.42%   82.31%   -2.12%     
==========================================
  Files          11       14       +3     
  Lines         764     1238     +474     
==========================================
+ Hits          645     1019     +374     
- Misses         77      156      +79     
- Partials       42       63      +21     
Impacted Files Coverage Δ
statuspage/data_source_component_groups.go 90.62% <0.00%> (-0.15%) ⬇️
statuspage/helpers.go 100.00% <ø> (ø)
statuspage/resource_component_group.go 87.73% <0.00%> (-0.45%) ⬇️
statuspage/resource_metric_provider.go 78.94% <0.00%> (+0.13%) ⬆️
statuspage/resource_subsriber.go 79.66% <0.00%> (-0.99%) ⬇️
statuspage/provider.go 89.83% <50.00%> (-1.55%) ⬇️
statuspage/internal/hashcode/hashcode.go 66.66% <66.66%> (ø)
statuspage/internal/go-retryablehttp/client.go 71.05% <71.05%> (ø)
statuspage/resource_component.go 86.95% <76.47%> (+0.49%) ⬆️
...atuspage/internal/go-retryablehttp/roundtripper.go 80.00% <80.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cae4f0...ed52b15. Read the comment docs.

@sbecker59 sbecker59 added enhancement New feature or request go Pull requests that update Go code labels Jun 13, 2021
@sbecker59 sbecker59 force-pushed the feat/go-retryablehttp branch 3 times, most recently from 7c19959 to c0bffdf Compare June 23, 2021 19:26
@sbecker59 sbecker59 force-pushed the feat/go-retryablehttp branch from c0bffdf to 0658d85 Compare June 23, 2021 19:33
@sbecker59 sbecker59 force-pushed the feat/go-retryablehttp branch from 0658d85 to ed52b15 Compare June 23, 2021 19:43
@sbecker59 sbecker59 merged commit f87b7f0 into main Jun 23, 2021
@sbecker59 sbecker59 deleted the feat/go-retryablehttp branch June 23, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Diagnostics
1 participant