Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code: Update minimum requirements to nvim 0.7 #151

Merged
merged 11 commits into from
Aug 25, 2023

Conversation

saccarosium
Copy link
Collaborator

@saccarosium saccarosium commented Aug 3, 2023

This PR does the following:

  • adds .editorconfig: for better style consistency (supported natively in neovim 0.9)
  • remove deprecated paq method
  • now is required neovim 0.7 and above
  • creates commands with lua api
  • track status with Enum like table
    • removing exists key
    • created filter table to make it more easy filter packages
  • iterating over lockfile functionality

@saccarosium saccarosium force-pushed the refactor_code branch 3 times, most recently from f8c8585 to 988a8c6 Compare August 5, 2023 22:45
@savq
Copy link
Owner

savq commented Aug 5, 2023

@saccarosium can you create a separate PR for the function encode issue? So we can merge that now, and merge the breaking stuff later.

@saccarosium
Copy link
Collaborator Author

@savq sure see #153! I think this PR is complete now. I will work now on the iterate over the state management, but first I will wait you to merge #152.

@saccarosium saccarosium changed the title Refactor code Refactor code: Update minimum requirements to nvim 0.7 Aug 6, 2023
@saccarosium
Copy link
Collaborator Author

@savq I've added some of the commits I've been working on my other branch. I felt that this changes made this PR more solid putting it in a better shape.

README.md Outdated Show resolved Hide resolved
Instead of having of having a separate key to evaluate if the directory
is installed or not I've made the following changes to status enum:
- INSTALLED: equivalent to the old exists key
- LISTED: a package is in the paq list but it isn't yet been installed
- CLONED: equivalent to what installed used to mean, a package was
  recently cloned (aka installed) on the machine.

Also to simplify the filtering of packaging based on the status I've
made a new table called 'filters' that help filter packages both in
'vim.tbl_filter' and regular if statements.
saccarosium and others added 2 commits August 9, 2023 22:19
Instead of saving the state on the function 'exe_op' I save the state on
every individual function that alter the state. I find this to be more
reliable.
@saccarosium
Copy link
Collaborator Author

@savq I think we need to merge our PRs into a separate branch for now and test there the changes there.

@savq savq changed the base branch from master to dev August 25, 2023 18:13
@savq
Copy link
Owner

savq commented Aug 25, 2023

Yes. I'll merge this to dev, and later I'll also merge 152.

@savq savq merged commit a0e6ff6 into savq:dev Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants