Using Savon mocks, cannot stub a request without a message.

[jessegoodnoe]

Per the documentation, I'd expect that I could stub a request without a message and with a return. But when there's an actual request that has a message, the expectation fails.

I would have thought that stubbing the request without a message would allow any message on the actual request.

From: http://savonrb.com/version2.html#options

If you're trying to "stub" a request, you can simply leave out the #with method, but you need to call the #returns method to return a response that Savon can work with.

Example

Here's an rspec example that illustrates what I'm trying to do. It can be put into spec/savon/mock_spec.rb.

  it "works with no message and a return" do
    authentication_message = { :username => "luke", :password => "secret" }
    savon.expects(:authenticate).returns("<fixture/>")
    expect { new_client.call(:authenticate, :message => authentication_message) }.to_not raise_error
  end

[rubiii]

thanks. i'll test that.

[rubiii]

i was a little confused by this as well, but as it turns out, there's actually a spec for it.
i don't know if it makes sense to always have to specify the message in your tests though.

[jessegoodnoe]

I agree, I don't think you should always have to specify the message.

In my use case, I don't care what's in the message, I care about the return. Other stubbing frameworks I've used stub the method but don't care about the message unless it's specified.

My preference would be:

# Message required and must match. (existing functionality.)
savon.expects(:find_user).with(:message => some_message).returns("<fixture/>")

# Message is ignored whether it exists or not
savon.expects(:find_user).returns("<fixture/>")

But, maybe a way to fix it without breaking people's existing tests is something like this:

# Message required and must match. (existing functionality.)
savon.expects(:find_user).with(:message => some_message).returns("<fixture/>")
# No message expected (existing functionality.)
savon.expects(:find_user).returns("<fixture/>")

# Some message required, but contents don't matter
savon.expects(:find_user).with(:message => :any).returns("<fixture/>")

[rubiii]

thanks for following up. that would certainly be an easy fix. i think i'm ok with that.
i'm not having the time to do this, but if you want to give it a try ...

[jessegoodnoe]

Sure, but I'm not clear which fix you like, the (:message => :any) or changing the existing behavior so that the lack of a message will not result in an exception.

[rubiii]

oh sorry, i would go with the message: :any option for now, because it's backwards compatible.

[rubiii]

@jessegoodnoe any updates on this one?