Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo search on frontend #2058

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Demo search on frontend #2058

merged 3 commits into from
Mar 31, 2023

Conversation

sanyavertolet
Copy link
Member

This PR closes #2057

What's done:

  • Replaced stub demoList with functional one
  • Added demo filtering
  • Implemented useDebouncedDeferredRequest

How it looks:

2023-03-30.17.38.58.mov

@sanyavertolet
Demo search on frontend
660f7be 
### What's done:
* Replaced stub demoList with functional one
* Added demo filtering
* Implemented useDebouncedDeferredRequest

(#2057)
@sanyavertolet sanyavertolet added enhancement New feature or request frontend Tasks on frontend demo Issues and PRs related to save-demo service labels Mar 30, 2023
@sanyavertolet sanyavertolet self-assigned this Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited
Loading

Codecov Report

Merging #2058 (85766d7) into master (cf783eb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 85766d7 differs from pull request most recent head 4336239. Consider uploading reports for the commit 4336239 to get more accurate results

@@             Coverage Diff              @@
##             master    #2058      +/-   ##
============================================
- Coverage     33.15%   33.14%   -0.01%     
  Complexity      606      606              
============================================
  Files           331      331              
  Lines          8168     8185      +17     
  Branches        787      789       +2     
============================================
+ Hits           2708     2713       +5     
- Misses         5272     5281       +9     
- Partials        188      191       +3
Impacted Files Coverage Δ
...saveourtool/save/backend/service/ProjectService.kt 52.94% <ø> (ø)
...saveourtool/save/demo/controller/DemoController.kt 0.00% <0.00%> (ø)
...n/com/saveourtool/save/demo/service/DemoService.kt 0.00% <0.00%> (ø)
...components/basic/demo/welcome/DemoListComponent.kt 0.00% <0.00%> (ø)
...c/testsuiteselector/TestSuiteSelectorSearchMode.kt 0.00% <0.00%> (ø)
...frontend/components/inputform/InputWithDebounce.kt 25.00% <0.00%> (-8.34%) ⬇️
...com/saveourtool/save/frontend/utils/CustomHooks.kt 66.66% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sanyavertolet
Demo search on frontend
85766d7 
### What's done:
* Replaced stub demoList with functional one
* Added demo filtering
* Implemented useDebouncedDeferredRequest

(#2057)
@sanyavertolet sanyavertolet requested a review from nulls March 31, 2023 09:11
@sanyavertolet sanyavertolet enabled auto-merge (squash) March 31, 2023 09:40
@sanyavertolet sanyavertolet merged commit a70658a into master Mar 31, 2023
@sanyavertolet sanyavertolet deleted the feature/demo_search branch March 31, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheshiriks Cheshiriks Cheshiriks approved these changes

@nulls nulls nulls approved these changes

@orchestr7 orchestr7 Awaiting requested review from orchestr7

Assignees

@sanyavertolet sanyavertolet

Labels
demo Issues and PRs related to save-demo service enhancement New feature or request frontend Tasks on frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement demo search on frontend
3 participants
@sanyavertolet @nulls @Cheshiriks