Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SAUCE_VISUAL_BUILD_ID and SAUCE_VISUAL_CUSTOM_ID #6

Merged
merged 18 commits into from
Mar 19, 2024
Merged

Add support for SAUCE_VISUAL_BUILD_ID and SAUCE_VISUAL_CUSTOM_ID #6

merged 18 commits into from
Mar 19, 2024

Conversation

FriggaHel
Copy link
Contributor

@FriggaHel FriggaHel commented Mar 18, 2024 •
edited
Loading

One-line summary

Issue : IRIS-833

Description

  • Add support for SAUCE_VISUAL_BUILD_ID and SAUCE_VISUAL_CUSTOM_ID
  • Use StringUtils.IsNullOrEmpty() prior that also checks this is not blanks.
  • Use null-forgiving operator (!) after checks that ensure value is defined (like after string.IsNullOrEmpty. .netstandard2.0 does not permit inference (while .netstandard2.1 does).
  • Removed Warning of nullables fields in Library

Types of Changes

  • New feature (non-breaking change which adds functionality)

@FriggaHel FriggaHel requested a review from konraddysput March 18, 2024 18:47
@FriggaHel FriggaHel marked this pull request as ready for review March 18, 2024 18:47
@FriggaHel FriggaHel requested a review from konraddysput March 19, 2024 11:49
@FriggaHel FriggaHel merged commit 12de446 into main Mar 19, 2024
2 checks passed
@FriggaHel FriggaHel deleted the add-sauce-visual-custom-id-support branch March 19, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konraddysput konraddysput konraddysput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FriggaHel @konraddysput