Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure screenshots are recognized artifacts #994

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

alexplischke
Copy link
Contributor

Description

A platform side change (/assets endpoint) moved screenshot files to the screenshots field. Prior to this change, saucectl was ignoring this field as it expected screenshots to appear on the root level (as do other files).

Before fix:

❯ saucectl artifacts list 5648b0fc31c644b78621cf006ad899b3
┌────────────────────────────────────────────────┐
│ Items                                          │
────────────────────────────────────────────────
│ index.html                                     │
│ 583f7f084ebd4ef4b73abc88b09a78e9.last-run.json │
│ log.json                                       │
│ console.log                                    │
│ config.yml                                     │
│ junit.xml                                      │
│ video.mp4                                      │
│ flags.json                                     │
│ sauce-test-report.json                         │
└────────────────────────────────────────────────┘

After fix:

❯ saucectl artifacts list 5648b0fc31c644b78621cf006ad899b3

┌─────────────────────────────────────────────────────────────────┐
│ Items                                                           │
─────────────────────────────────────────────────────────────────
│ 660938d924107f5889cdb401f0417855fbd326f0.png                    │
│ 6eea30518519a29b942c24b7eec882e2c31a029e.png                    │
│ fc53f633a77f60048da6cffd8cee2b424378cd49.png                    │
│ screen-capture-png-02c5050b38fd8609e580a1db8238ba7cc9c6f8c7.png │
│ screenshot-56cd48708adc9c65ea0a247630c94e6504490b0c.png         │
│ screenshot-96f80502c0a1278713b7ab28522f9d97b0c97a89.png         │
│ screenshot.png                                                  │
│ console.log                                                     │
│ sauce-test-report.json                                          │
│ junit.xml                                                       │
│ log.json                                                        │
│ index.html                                                      │
│ config.yml                                                      │
│ video.mp4                                                       │
│ 583f7f084ebd4ef4b73abc88b09a78e9.last-run.json                  │
│ flags.json                                                      │
└─────────────────────────────────────────────────────────────────┘

@alexplischke alexplischke added the bug Something isn't working label Dec 13, 2024
@alexplischke alexplischke marked this pull request as ready for review December 13, 2024 02:26
@alexplischke alexplischke requested a review from a team as a code owner December 13, 2024 02:26
@alexplischke alexplischke merged commit 8685650 into main Dec 13, 2024
17 of 18 checks passed
@alexplischke alexplischke deleted the DEVX-3137 branch December 13, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants