Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename CI tags #984

Merged
merged 10 commits into from
Nov 28, 2024
Merged

feat: rename CI tags #984

merged 10 commits into from
Nov 28, 2024

Conversation

tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Nov 26, 2024

Description

Rename CI tags.

@tianfeng92 tianfeng92 added the enhancement New feature or request label Nov 26, 2024
}
case Bamboo:
return CI{
Provider: provider,
OriginURL: os.Getenv("bamboo_buildResultsUrl"),
Repo: os.Getenv("bamboo_planRepository_repositoryUrl"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terminologies: In Bamboo CI, a plan organizes a series of jobs and their associated configurations. position is the index of a repository in the plan's configuration. The default position is 0.

The variable bamboo_planRepository_repositoryUrl is now replaced with bamboo_planRepository_<position>_repositoryUrl. There’s no way to dynamically retrieve position.
For commit SHA information, the only available variable is bamboo_planRepository_<position>_revision, which also depends on <position>. The value cannot be accurately determined.

Based on these, I removed the repo url and revision.

Reference: https://confluence.atlassian.com/bamboo/bamboo-variables-289277087.html

Note: How can these variables be accessed as environment variables?

Bamboo variables are exported as bash shell variables. All full stops (periods) are converted to underscores. For example, the variable bamboo.my.variable is $bamboo_my_variable in bash. This is related to File Script and Inline Script tasks.

@tianfeng92 tianfeng92 marked this pull request as ready for review November 27, 2024 17:57
@tianfeng92 tianfeng92 requested a review from a team as a code owner November 27, 2024 17:57
Copy link
Contributor

@alexplischke alexplischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal/ci/ci.go Outdated Show resolved Hide resolved
@tianfeng92 tianfeng92 merged commit 832439e into main Nov 28, 2024
15 checks passed
@tianfeng92 tianfeng92 deleted the DEVX-3112 branch November 28, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants