Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix smart retry in XCUITest simulator test #873

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Conversation

tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Jan 13, 2024

Proposed changes

In the current JUnit report, the classname follows the class.testMethod pattern. However, this format is not suitable for filtering out failed tests in smart retry tests. This PR is proposed to update the classname to the class/testMethod format.

Initial test: https://app.saucelabs.com/tests/fb0d832bc6d644c58beebe1415d229c5#1
Retried test: https://app.saucelabs.com/tests/b6d20f0fd20345bea7eb463d1e7f105c#1

Verified, real device test remains unaffected.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

@tianfeng92 tianfeng92 added the bug Something isn't working label Jan 13, 2024
@tianfeng92 tianfeng92 requested a review from a team as a code owner January 13, 2024 02:06
Copy link
Contributor

@alexplischke alexplischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes like these need better in-code documentation, as it's not clear by reading the code alone why things are the way they are.

internal/saucecloud/retry/junitretrier.go Outdated Show resolved Hide resolved
@alexplischke alexplischke self-requested a review January 17, 2024 00:02
@alexplischke alexplischke merged commit 5a3c78c into main Jan 17, 2024
18 checks passed
@alexplischke alexplischke deleted the devx-2709 branch January 17, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants