Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle fullscreen functionality #91

Closed
wants to merge 0 commits into from

Conversation

muhammadcahya
Copy link
Contributor

Description

Add toggle fullscreen functionality

Types of changes

Added toggle fullscreen functionality

image

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Others (any other types not listed above)

Checklist

Related Issue

#75

Closes: #75

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for shadcn-admin ready!

Name Link
🔨 Latest commit 93be363
🔍 Latest deploy log https://app.netlify.com/sites/shadcn-admin/deploys/67abe541e3991b0008abb65b
😎 Deploy Preview https://deploy-preview-91--shadcn-admin.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@satnaing satnaing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to be working as expected on mobile devices.
Is it intentional? Coz I'm not very familiar with this DOM API.

Comment on lines 21 to 25
{isFullscreen ? (
<Minimize className='h-5 w-5' />
) : (
<Maximize className='h-5 w-5' />
)}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic does not work if you go to full-screen mode, then navigate between pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: FullScreen Mode (Default F11)
2 participants