Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow changing font family in setting #84

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

AliAkrem
Copy link
Contributor

Description

Add dynamic font selection with localStorage persistence

Types of changes

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Others (any other types not listed above)

Checklist

Further comments

Screencast.from.2025-01-24.20-52-28.webm

Related Issue

Closes: #83

Copy link

netlify bot commented Jan 25, 2025

Deploy Preview for shadcn-admin ready!

Name Link
🔨 Latest commit f8b83bf
🔍 Latest deploy log https://app.netlify.com/sites/shadcn-admin/deploys/679a2963ac1fe80008a0c372
😎 Deploy Preview https://deploy-preview-84--shadcn-admin.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- update formatting to fix Prettier issues
- improve type safety and allow easier configuration
- add safelist inside `tailwind.config.js` to prevent font-related class purging
@satnaing
Copy link
Owner

Thanks for your PR @AliAkrem

I made some changes + improvements

  • solve prettier issues
  • enhance type safety and make it more configurable.
  • add safelist inside tailwind.config.js to avoid unexpected font-related class purging.

@satnaing satnaing changed the title Add/appearance font family feat: allow changing font family in setting Jan 29, 2025
@satnaing satnaing merged commit 787b466 into satnaing:main Jan 29, 2025
5 checks passed
@AliAkrem AliAkrem deleted the add/appearance-font-family branch January 29, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Implement Dynamic Font Selection with Persistence
2 participants