Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just a tiny suggestion #7531

Closed
wants to merge 1 commit into from
Closed

just a tiny suggestion #7531

wants to merge 1 commit into from

Conversation

opitzl
Copy link

@opitzl opitzl commented Jul 5, 2023

Dear Seurat-Dev-Team,
it would be nice if the Read10X function
would support an optional prefix in the CellRanger output data or to read 10X data from GEO without renaming.

@samuel-marsh
Copy link
Collaborator

samuel-marsh commented Jul 5, 2023

Agree this would be great if implemented.

In meantime as fyi I have written functions to handle such situations (GEO files etc) in my package scCustomize. Read10X_GEO can read in one or more files from same directory with prefixes and if you are reading all files doesn’t require you to specify prefix or files to share prefix (will return list with entries named by prefix).
https://samuel-marsh.github.io/scCustomize/articles/Read_and_Write_Functions.html

Best,
Sam

EDIT. Also apologies if the images are not displaying in vignette linked (they aren’t on mobile for me currently). Will update site next week with new package version release coming.

@samuel-marsh
Copy link
Collaborator

samuel-marsh commented Jul 7, 2023

Will also add if you want Seurat native solution you can simply use ReadMtx function.

Best,
Sam

@samuel-marsh
Copy link
Collaborator

Also actually just remembered ReadMtx was solution added when I sent similar PR while back #4101 . So think that will likely remain supported solution to file prefix/non-standard names.

Best,
Sam

@saketkc
Copy link
Collaborator

saketkc commented Jul 7, 2023

Hi @opitzl and @samuel-marsh, thanks for the suggestion and discussion. We think ReadMtx is a versatile approach to handle these cases. Thanks for your PR @opitzl - we really appreciate it, but also want to keep the technology specific methods (such as 10X) to do exactly one task. Please use ReadMtx for other use cases.

@saketkc saketkc closed this Jul 7, 2023
@samuel-marsh
Copy link
Collaborator

Thought as much based on our previous conversations! Thanks again @saketkc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants