Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Color Option to JackStrawPlot #4149

Merged
merged 9 commits into from
Feb 27, 2021
Merged

Add Color Option to JackStrawPlot #4149

merged 9 commits into from
Feb 27, 2021

Conversation

samuel-marsh
Copy link
Collaborator

Hi Seurat Team,

Straightforward PR adding cols parameter to JackStrawPlot to aid in visualization/distinction between PCs that can be difficult with default hue palette depending on the number of PCs plotted.

Thanks!
Sam

@samuel-marsh
Copy link
Collaborator Author

samuel-marsh commented Feb 25, 2021

As note I created this branch off of my forked dev branch which already had the pending PR regarding GEO changes and Read10X so this PR contains commits which revert the branch to be equivalent to current Seurat Dev branch before adding the new changes to JackStrawPlot.

@andrewwbutler andrewwbutler merged commit c5f0e9d into satijalab:develop Feb 27, 2021
@andrewwbutler
Copy link
Collaborator

Thanks Sam!

@samuel-marsh
Copy link
Collaborator Author

Happy to help!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants