Update to new JSON messaging standard #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to coincide with a change to the LiveSplit.Server repo
See LiveSplit/LiveSplit.Server#39 for more details
At very fast polling intervals, the socket will sometimes send more than one message from the server in a single 'data' event. This change gracefully handles these edge cases, resulting in successful tests at as fast as polling every 5ms.
|
Thank you for your PR! |
|
Also, new LiveSplit server version must be released before I merge this into main branch. |
|
Yeah, for sure, no worries! |
|
This PR is pretty outdated. Let's coma back to this issue when server changes would be applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See LiveSplit/LiveSplit.Server#39 for more
details.
Also fixes a bug (or rather just weird edge case interaction) with the socket data listener where multiple messages would get combined into one at very fast polling rates. I was able to run
.getAll()every 5ms without errors at my fastest testing with these changes.