Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for css empty namespace attribute selector #1742

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Conversation

pjeweb
Copy link
Contributor

@pjeweb pjeweb commented Nov 16, 2021

see sass/sass#3199 [skip dart-sass]

@stof
Copy link
Contributor

stof commented Nov 16, 2021

This PR should have [skip dart-sass] in its description, to avoid running the CI against the unpatched dart-sass version, as described in https://github.com/sass/dart-sass/blob/main/CONTRIBUTING.md#changing-the-language

@pjeweb
Copy link
Contributor Author

pjeweb commented Nov 16, 2021

The skip tag should be added now?!

@stof
Copy link
Contributor

stof commented Nov 16, 2021

@pjeweb yeah, things look good now. You just need to wait for a maintainer to approve the workflow run, as you are a first-time contributor (I'm not a maintainer, only a contributor, so I cannot approve it myself)

by removing the operator and right-hand value as this gets quoted in LibSass but not dart-sass. [skip dart-sass]
pjeweb added a commit to pjeweb/dart-sass that referenced this pull request Nov 16, 2021
Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@nex3 nex3 merged commit bc6d5eb into sass:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants