Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Fix document when returning both file and contents in custom importer #2501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtsmfm
Copy link

@mtsmfm mtsmfm commented Sep 22, 2018

ref: pmowrer/node-sass-json-importer#74

I think our document about custom importer is wrong.
It seems node-sass already considers returning both file and contents.

// resolved abs_path should be set by custom importer
// use the created uniq_path as fallback (maybe enforce)
std::string path_key(abs_path ? abs_path : uniq_path);

@saper saper self-requested a review October 18, 2019 04:19
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
Fix issue when passing restargs to call
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants