This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Fix document when returning both file
and contents
in custom importer
#2501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: pmowrer/node-sass-json-importer#74
I think our document about custom importer is wrong.
It seems node-sass already considers returning both
file
andcontents
.node-sass/src/libsass/src/context.cpp
Lines 512 to 514 in 746759c