Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Remove Node 0.10 and 0.12 from CI config #2112

Merged
merged 3 commits into from
Oct 6, 2017
Merged

Remove Node 0.10 and 0.12 from CI config #2112

merged 3 commits into from
Oct 6, 2017

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Oct 6, 2017

These will always fails now due to #2100. We manually verify support when building release binaries so there's no value in failing CI. It's scary to contributors.

These will always fails now due to #2100. We manually verify support when building release binaries so there's no value in failing CI. It's scary to contributors.
@xzyfer xzyfer changed the title Remove Node 0.10 and 0.12 from travis config Remove Node 0.10 and 0.12 from CI config Oct 6, 2017
These will always fails now due to #2100. We manually verify support when building release binaries so there's no value in failing CI. It's scary to contributors.
@xzyfer xzyfer requested a review from nschonni October 6, 2017 04:12
Copy link
Contributor

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd probably drop 7 at the same time too

edit: 5 as well

Help people search for keywords because noone reads the help guides anyway.
@xzyfer
Copy link
Contributor Author

xzyfer commented Oct 6, 2017

I think a lot of people are still using 7. I know my work is, which is plenty enough reason for me to keep it around :)

@xzyfer
Copy link
Contributor Author

xzyfer commented Oct 6, 2017

Added a note to the readme linking to the troubleshooting entry

@nschonni
Copy link
Contributor

nschonni commented Oct 6, 2017

OK, but for the node-sass@5, I think all the unsupported versions should go away. Especially since the odd number releases just roll into the even ones when they go stable

@xzyfer
Copy link
Contributor Author

xzyfer commented Oct 6, 2017

Agreed. Active LTS and current is nice but forces us to bump the major every 12 months to drop odd number releases. I think this is ok, but time will tell.

@xzyfer xzyfer merged commit e934a55 into master Oct 6, 2017
@xzyfer xzyfer deleted the old-node branch October 6, 2017 05:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants