[BUGFIX] Add fix for source-maps (Fix-Up PR #591) #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove line-breaks in Base64 encoded string - Actually embed the source-map json in data-url - Include original source in sources array
|
It makes perfect sense. Actually other trans-compilers (less.js for instance) also add the actual source-file-path in the sources array. |
mgreter
added a commit
that referenced
this pull request
Nov 4, 2014
[BUGFIX] Add fix for source-maps (Fix-Up PR #591)
|
@mgreter, just tested locally, and it passes all the node-sass tests. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some bugs which I unfortunately just discovered now (#591)!
IMO the last one will probably cause some test fails for node sass! /cc @am11, @andrew
The sources array should contain the initial source too, as there is no other way to get it otherwise.
IMO I've just added a fix for that, so node sass tests pass. After some re-thinking I came to the conclusion that it has to be the way as this PR implements it!
Best regards