-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STYLE_ constants obeyed #15
Comments
Yes, all the output styles will be implemented. It's currently a low priority compared to other features such as full interpolation and selector inheritance. |
Awww, we didn't mean to ruin your excitement. On Tue, May 1, 2012 at 6:05 AM, Jamie Rumbelow <
|
We also would like to see compressed! |
I'll be getting this feature in by the end of the month! |
Added support for compressed output styles. Please give it a try! |
Not working for me. Getting an empty output |
Can you provide more details on how you're invoking LibSass? It's been working for us. |
Using SassC |
Oh, the SassC command-line tool is still hard-coded to use the nested style (haven't had time to update that yet!). To use the compressed style, you currently have to set the flag in the C interface when invoking LibSass as a library. |
I'm just working on sassc flag handling now. Is it ok to use getopt or does it need to be Windows friendly? |
Hmm ... preferably Windows-friendly, but that's less of a priority than keeping the core library itself portable. So I'd say go ahead and use getopt if it makes things much easier and more robust. Thanks for the help! |
Sorry if i being a bit dense - dont have much experience with C Changed the sassc.c file line 16 to ctx->options.output_style = SASS_STYLE_COMPRESSED; Then ran make Output is now empty |
Have you updated the libsass submodule? Try going into the |
That did it! Thanks for the help... |
No problem! And let me know if the styles don't look right! |
Will be testing tomorrow. Ill let you know if there any problems! |
Isn't Supposedly, a > b > c {
declaration }
a > b > c > d {
declaration1;
declaration2; } and the a > b > c
{
declaration;
}
a > b > c > d
{
declaration1;
declaration2;
} Then there might be a requirement which begs another kind of nested expansion: a > b > c
{
declaration;
}
a > b > c > d
{
declaration1;
declaration2;
} So, wouldn't it make sense to have just two styles: On a related note, both kind of outputs should get the _detailed_ source maps pinpointing the location for each source-to-source artifacts (exactly how |
We are trying to match the styles produced by the Ruby implementation. I'm going to close this since the issue is actually about the constants, not compatibility with Ruby sass. |
I got all excited about adding different output styles to my libsass binding to discover that only
SASS_STYLE_NESTED
is working!Are there still plans to make the other style constants work?
The text was updated successfully, but these errors were encountered: