Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubly quoted strings work different from Ruby Sass #1215

Closed
mirisuzanne opened this issue May 15, 2015 · 4 comments · Fixed by #1247
Closed

Doubly quoted strings work different from Ruby Sass #1215

mirisuzanne opened this issue May 15, 2015 · 4 comments · Fixed by #1247

Comments

@mirisuzanne
Copy link

The output from my webfont toolkit changed with the latest libsass update. What used to output ../fonts/rockingham-bolditalic-webfont.woff now returns ../fonts/"rockingham-bolditalic-webfont.woff". I'm having trouble tracking down the source of that problem, but I have found some related string-quoting inconsistencies.

.test {
  -quotes: 'this-string' == 'this-string';
  -quotes: this-string == 'this-string';
  -quotes: 'this-string' == "this-string";
  -quotes: 'this-string' == '"this-string"';
  -quotes: '"this-string"' == "'this-string'";
}

Libsass returns true for all 5 comparisons. Ruby Sass returns false for the last 2 — which would seem more appropriate, since they are treated differently by both libsass and ruby sass:

// input
.inspect {
  -string: 'this-' + '"string"';
  -string: 'this-' + 'string';
}

// output
.inspect {
  -string: 'this-"string"';
  -string: "this-string";
}
@mirisuzanne
Copy link
Author

Also, using @debug, it is impossible to tell the difference between any of these. The quotes never appear.

@mirisuzanne
Copy link
Author

Oddly, my larger issue was fixed by changing url('#{$font-path}#{$path}') to url($font-path + $path). Does that make sense to anyone?

xzyfer added a commit to xzyfer/sass-spec that referenced this issue May 28, 2015
@xzyfer
Copy link
Contributor

xzyfer commented May 28, 2015

Spec added sass/sass-spec#397

@xzyfer
Copy link
Contributor

xzyfer commented May 28, 2015

Apologies for the radio silence @ericam. This will be fixed in 3.2.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants