Skip to content

Commit

Permalink
Excludes external libraries from code coverage
Browse files Browse the repository at this point in the history
They provide far more code than we actually use.
And we certainly don't want to test all that code!
Reverts back to using longhand options in travi-ci!
Fixes some minor clang warnings in sass.cpp.
  • Loading branch information
mgreter committed Nov 1, 2014
1 parent 6c7fcd2 commit bff1afc
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 7 deletions.
8 changes: 7 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,13 @@ install:

after_success:
# exclude some directories from profiling (.libs is from autotools)
- export EXCLUDE_COVERAGE="--exclude sassc --exclude sass-spec --exclude .libs"
- export EXCLUDE_COVERAGE="--exclude sassc --exclude sass-spec \
--exclude .libs --exclude debug.hpp \
--exclude json.cpp --exclude json.hpp \
--exclude cencode.c --exclude b64 \
--exclude utf8 --exclude utf8_string.hpp \
--exclude utf8.h --exclude utf8_string.cpp \
--exclude test"
# debug via gcovr
- gcovr -r .
# debug via coveralls (dump result for futher analyzing)
Expand Down
12 changes: 6 additions & 6 deletions sass.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,15 @@ extern "C" {

size_t i;
switch(val.unknown.tag) {
// case SASS_NULL: {
// } break;
// case SASS_BOOLEAN: {
// } break;
case SASS_NULL: {
} break;
case SASS_BOOLEAN: {
} break;
case SASS_NUMBER: {
free(val.number.unit);
} break;
// case SASS_COLOR: {
// } break;
case SASS_COLOR: {
} break;
case SASS_STRING: {
free(val.string.value);
} break;
Expand Down

0 comments on commit bff1afc

Please sign in to comment.