Fix IsCalculationSafe.visitBinaryOperationExpression (#2524)

This was previously checking whether *either* operator was
calculation-safe, when in fact it should check that *both* are.

Closes #2523

CHANGELOG.md

@@ -1,6 +1,9 @@
-## 1.85.1-dev
+## 1.85.1
 
-* No user-visible changes.
+* Fix a bug where global Sass functions whose names overlap with CSS math
+  functions could incorrectly be treated as CSS math functions even though they
+  used Sass-only features, causing compilation failures. For example,
+  `round(-$var / 2)` previously threw an error but now works as intended.
 
 ## 1.85.0
 

lib/src/visitor/is_calculation_safe.dart

@@ -27,7 +27,8 @@ class IsCalculationSafeVisitor implements ExpressionVisitor<bool> {
         BinaryOperator.plus,
         BinaryOperator.minus,
       }).contains(node.operator) &&
-      (node.left.accept(this) || node.right.accept(this));
+      node.left.accept(this) &&
+      node.right.accept(this);
 
   bool visitBooleanExpression(BooleanExpression node) => false;
 

pkg/sass-parser/CHANGELOG.md

@@ -1,4 +1,4 @@
-## 0.4.15-dev
+## 0.4.15
 
 * Add support for parsing list expressions.
 

pkg/sass-parser/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sass-parser",
-  "version": "0.4.15-dev",
+  "version": "0.4.15",
   "description": "A PostCSS-compatible wrapper of the official Sass parser",
   "repository": "sass/sass",
   "author": "Google Inc.",

pkg/sass_api/CHANGELOG.md

@@ -1,4 +1,4 @@
-## 15.2.1-dev
+## 15.2.1
 
 * No user-visible changes.
 

pkg/sass_api/pubspec.yaml

@@ -2,7 +2,7 @@ name: sass_api
 # Note: Every time we add a new Sass AST node, we need to bump the *major*
 # version because it's a breaking change for anyone who's implementing the
 # visitor interface(s).
-version: 15.2.1-dev
+version: 15.2.1
 description: Additional APIs for Dart Sass.
 homepage: https://github.com/sass/dart-sass
 

pubspec.yaml

@@ -1,5 +1,5 @@
 name: sass
-version: 1.85.1-dev
+version: 1.85.1
 description: A Sass implementation in Dart.
 homepage: https://github.com/sass/dart-sass