Make EventQueue a virtual class

Summary: Changelog: [internal] EventQueue is used as a virtual class, this diff makes it one. Reviewed By: JoshuaGross, shergin Differential Revision: D25826983 fbshipit-source-id: 60e6937514cd3b837b0ca9f61bfaa081823ffc61
sasmit · Jan 7, 2021 · deda351 · deda351
1 parent f2052fe
commit deda351
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 9 deletions.
diff --git a/ReactCommon/react/renderer/core/BatchedEventQueue.cpp b/ReactCommon/react/renderer/core/BatchedEventQueue.cpp
@@ -17,8 +17,6 @@ BatchedEventQueue::BatchedEventQueue(
     : EventQueue(eventPipe, statePipe, std::move(eventBeat)) {}
 
 void BatchedEventQueue::onEnqueue() const {
-  EventQueue::onEnqueue();
-
   eventBeat_->request();
 }
 

diff --git a/ReactCommon/react/renderer/core/EventQueue.cpp b/ReactCommon/react/renderer/core/EventQueue.cpp
@@ -48,10 +48,6 @@ void EventQueue::enqueueStateUpdate(const StateUpdate &stateUpdate) const {
   onEnqueue();
 }
 
-void EventQueue::onEnqueue() const {
-  // Default implementation does nothing.
-}
-
 void EventQueue::onBeat(jsi::Runtime &runtime) const {
   flushEvents(runtime);
   flushStateUpdates();

diff --git a/ReactCommon/react/renderer/core/EventQueue.h b/ReactCommon/react/renderer/core/EventQueue.h
@@ -51,7 +51,7 @@ class EventQueue {
    * Override in subclasses to trigger beat `request` and/or beat `induce`.
    * Default implementation does nothing.
    */
-  virtual void onEnqueue() const;
+  virtual void onEnqueue() const = 0;
   void onBeat(jsi::Runtime &runtime) const;
 
   void flushEvents(jsi::Runtime &runtime) const;

diff --git a/ReactCommon/react/renderer/core/UnbatchedEventQueue.cpp b/ReactCommon/react/renderer/core/UnbatchedEventQueue.cpp
@@ -11,8 +11,6 @@ namespace facebook {
 namespace react {
 
 void UnbatchedEventQueue::onEnqueue() const {
-  EventQueue::onEnqueue();
-
   eventBeat_->request();
   eventBeat_->induce();
 }