Allow resolution adaption of the captured screen #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarxos
reviewed
Oct 25, 2017
| BufferedImage screen = robot.createScreenCapture(bounds); | ||
| int width = resolution.width; | ||
| int height = resolution.height; | ||
| BufferedImage img = new BufferedImage(width, height, screen.getType()); |
There was a problem hiding this comment.
Please consider checking if screen image from Robot has the same size as resolution Dimension and return original screen image in such a case, so we do not need to create resized image when it's unnecessary.
if (screen.getWidth() == width && screen.getHeight() == height) {
return screen;
}|
Hi @gubjack, thank you for this PR :) This is really nice functionality. I added one comment in regards to the changes you made. |
|
You’re welcome!
I’ll take care the next days. To much other work …
Hagen
… Am 25.10.2017 um 09:40 schrieb Bartosz Firyn ***@***.***>:
Hi @gubjack <https://github.com/gubjack>, thank you for this PR :) This is really nice functionality. I added one comment in regards to the changes you made.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#569 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASZ8FgZfVd8ponBrO_R4Cp5zdcAtrMDIks5svuXwgaJpZM4QFd_w>.
|
|
Sure. I can merge this now and add mentioned fix later if you like. |
…esired resolution
|
Thank you @gubjack! I'm merging this. |
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be useful the adapt the resolution of a captured screen as one would be able with a normal camera.