Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multiple points for source of motion #350

Merged
merged 2 commits into from
Jun 2, 2015
Merged

Added support for multiple points for source of motion #350

merged 2 commits into from
Jun 2, 2015

Conversation

tm1990
Copy link
Contributor

@tm1990 tm1990 commented May 30, 2015

Adds support for multiple points when using motion detection.
It has a range and max variable to be able to decrease/increase the amount of points that are detected

Since without this you can only get one accurate position at a time when detecting motion this will allow to look for multiple positions at the same time.

Someelse should probably look through this since i am not too experienced in java and specially not in this area but it seems to be working from what i have tested.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 12.15% when pulling 5686cd4 on tm1990:master into 9827348 on sarxos:master.

@sarxos
Copy link
Owner

sarxos commented Jun 1, 2015

Hi @tm1990,

Thank you for the pull request. This is very nice and well done feature! I had some low priority comments in regards to the code and it would be great if you can address them when you have some time (especially, some example demonstrating multiple points detection use-case would be very helpful to the users).

Please let me know if you like to add changes to this pull request or shall I merge this one and you will craft second one for the fixes.

@tm1990
Copy link
Contributor Author

tm1990 commented Jun 1, 2015

I can make those changes and add them to this one a little bit later today when i have some free time.

And sure i can see about making a small example

@sarxos
Copy link
Owner

sarxos commented Jun 1, 2015

Ok, thank you!

@tm1990
Copy link
Contributor Author

tm1990 commented Jun 1, 2015

Added a small example for the multi-point motion detection. Probably terrible but that is at least what i was trying to create when i made the multi point changes
Also change the points variable to lower-case
And for the space/tabs thing is there any specific areas to which i have used spaces that you could see? At least from what i saw i think i have use tabs

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 12.26% when pulling 41bce6b on tm1990:master into 9827348 on sarxos:master.

@sarxos
Copy link
Owner

sarxos commented Jun 2, 2015

@tm1990,

The problem with tabs is probably caused by your IDE which is converting them to spaces, but don't worry - this is not blocking and I can convert them later to the appropriate ones.

Thank you!

sarxos added a commit that referenced this pull request Jun 2, 2015
Added support for multiple points for source of motion
@sarxos sarxos merged commit 1a8501f into sarxos:master Jun 2, 2015
@tm1990
Copy link
Contributor Author

tm1990 commented Jun 2, 2015

Ok i will look at that in case i have to make any other pull requests here.
And no problem. Glad i could actuly help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants