-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for multiple points for source of motion #350
Conversation
Hi @tm1990, Thank you for the pull request. This is very nice and well done feature! I had some low priority comments in regards to the code and it would be great if you can address them when you have some time (especially, some example demonstrating multiple points detection use-case would be very helpful to the users). Please let me know if you like to add changes to this pull request or shall I merge this one and you will craft second one for the fixes. |
I can make those changes and add them to this one a little bit later today when i have some free time. And sure i can see about making a small example |
Ok, thank you! |
Added a small example for the multi-point motion detection. Probably terrible but that is at least what i was trying to create when i made the multi point changes |
The problem with tabs is probably caused by your IDE which is converting them to spaces, but don't worry - this is not blocking and I can convert them later to the appropriate ones. Thank you! |
Added support for multiple points for source of motion
Ok i will look at that in case i have to make any other pull requests here. |
Adds support for multiple points when using motion detection.
It has a range and max variable to be able to decrease/increase the amount of points that are detected
Since without this you can only get one accurate position at a time when detecting motion this will allow to look for multiple positions at the same time.
Someelse should probably look through this since i am not too experienced in java and specially not in this area but it seems to be working from what i have tested.