Customizable WebcamUpdater; issue #307 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling d4645fe on krok32:master into * on sarxos:master*. |
|
Hi @krok32, Thank you for this pull request :) The formatting is correct and I see no issues within the code. I had only one low priority comment in regards to I'm merging it into the master. |
sarxos
added a commit
that referenced
this pull request
Feb 14, 2015
Customizable WebcamUpdater; issue #307
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the first pull request regarding the issue #307
I imported the format.xml to the eclipse, so i hope the formatting is ok.