Painter enhancements in WebcamPanel #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarxos
added a commit
that referenced
this pull request
Feb 4, 2014
Painter enhancements in WebcamPanel
|
Hi @syliks, These are awesome features :) I will be happy to merge them into the official distribution. Don't worry about the failed build on Travis - I've checked the build logs and seems like it's caused by the Maven artifact download problem (some kind of repository connectivity issue). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sarxos, as per our discussions, those are enhancements I made in WebcamPanel class. I hope all are useful. Additionally I fixed on bug in execution scheduling when panel was in "starting" phase - please see detailed explanation in source code. One other enhancement is in WebcamDiscoveryService - previously you were able to stop it after it run for the first time, but there was no possibility to disable it at all (so it will never start, by intention). Please let me know if you have any doubts in regards of this code.