Device identifier

[oocanto]

Hello, team.

I am using your incredible library and I have to say that you did a wonderful job. Congratulations.

By using your library, I noticed that we do not have an identifier for each device that is discovered in local machine. Regarding to that, I shall make a very dummy question:

Since com.github.sarxos.webcam.ds.buildin.natives.Device class has a getIdentifierStr() method, is it possible to make it accessible from implementations of com.github.sarxos.webcam.WebcamDevice interface across a getId() method by returning a java.lang.String value? I did that locally (Windows XP SP2), and it seems to work fine. It is a simple change in com.github.sarxos.webcam.ds.buildin.WebcamDefaultDevice class.

Being all for now, I look forward to hearing from you soon.

Thank you.

Best regards.

[sarxos]

Hi @oocanto,

I see no issue in adding new method String getId() to WebcamDefaultDevice class, but I have objections in regards to exposing it via WebcamDevice interface. The problem I see is the fact that webcam ID is available if and only if one is using default driver from OpenIMAJ. In case of all other drivers (e.g. GStreamer, FS Webcam, OpenCV and others) only webcam name is available (or address, in OpenCV only). Therefore, adding something non-common to one of the main interfaces is imho questionable.

[sarxos]

I'm closing this ticket as getId() has been added to WebcamDefaultDevice. The WebcamDevice interface remains unchanged.