Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail parsing due to single errors #227

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Don't fail parsing due to single errors #227

merged 3 commits into from
Apr 23, 2020

Conversation

techalchemy
Copy link
Member

@techalchemy
Don't fail parsing due to single errors
ded4caf 
- Fixes #226

Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
@ghost
Copy link

ghost commented Apr 23, 2020 •
edited by ghost
Loading

DeepCode's analysis on #dea8af found:

⚠️ 1 warning ✔️ 0 issues were fixed.

👉 View analysis in DeepCode’s Dashboard

☺️ If you want to provide feedback on our bot, here is how to contact us.

@techalchemy
Call the right function to parse the AST
dea8af5 
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
@techalchemy
fix requirement building
cc4cd33 
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
@techalchemy techalchemy merged commit 159a845 into master Apr 23, 2020
@techalchemy techalchemy deleted the bugfix/226 branch April 23, 2020 06:30
@jayvdb jayvdb mentioned this pull request Nov 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AST Parsing should try to fail silently if possible
1 participant
@techalchemy