Validation using pure python #57
Conversation
24442fb to
c6b3bf3
Compare
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
c6b3bf3 to
e03c20b
Compare
|
Note, I intend to release this version as 2.0.0 and mark 1.0.0 as obsolete. There are no "new features" here, but it's again a complete rewrite. |
Pipenv's integration tests reveal that plette's test suite was a bit too simplistic. tomlkit parsed the following package spec: zipp = 1.11 as a tomlkit.items.Float, which causes the validation to break. This commit handles this and add unit and integration test case for this. Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
| import pytest | ||
| from plette import models | ||
|
|
||
| def test_requires_python_version(): |
There was a problem hiding this comment.
I am wondering if we should have more tests around the Requires model -- noticed this is getting removed.
There was a problem hiding this comment.
This seems as it is getting removed, because on that branch I split the tests from one file to many small ones.
You can find these tests here:
Line 69 in e3fa787
And yes, I agree with you with need more tests! The current suite is very weak, and I have been working constantly to improve it (first, I did add all the examples/Pipfiles and the integration tests around them. This PR also adds another tests for a case which was caught in upstream merging.
I will add more in the near future.
Validation using dataclasses sounded like a great idea, and while I learned a lot from this experiment, I unfortunately released a broken version.
Despite all tests were passing, some public interfaces which were not tested caused severe errors.
Earlier versions of plette saved the original snippets parsed by
tomlkitas_dataattribute for each instance.These
containersbehave like dicts, but actually aren't. Hence, trying to model them as dictionaries and cast away theoriginal data proved tricky.
This refactor keeps the original approach of keeping the
tomlkitcontainers in_data. In addition, validation is now always enforced, as it does not depend on Cerberus.I believe this approach is simpler and easier to maintain. The real test though is if I can integrate this into pipenv without changing pipenv's tests or it's usage of plette.