Add quotes escaper method #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
488bd6b to
e99064e
Compare
QuirrelForU
commented
Jan 30, 2025
pomcorn/locators/base_locators.py
Outdated
Comment on lines
159
to
161
| @staticmethod | ||
| def _escape_quotes(text: str) -> str: | ||
| """Escape single and double quotes in given text for use in locators. # noqa: D202, E501. |
There was a problem hiding this comment.
noqa is used cuz for some reason flake tells that there is empty line 😕
ron8mcr
approved these changes
Jan 30, 2025
TheSuperiorStanislav
approved these changes
Jan 31, 2025
M1troll
requested changes
Jan 31, 2025
5832119 to
4a96b25
Compare
M1troll
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like for now there is some issue with pomcorn XpathLocators.
For example if I want to create a locator
I'll get this query:
but it won't work
Current implementation can handle this cases and we get