This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes does not have sense. Remove the affected code.
All parameters have been initializing their min and max value. This is an unimplemented feature and nowadays only make sense in paramrepeats. Fix it.
Basically do the same as in 1eb511a but also for new API of repeat parameters. All parameters have been initializing their min and max value. This is an unimplemented feature and nowadays only make sense in paramrepeats.
mimeData method works with bytes in Py3. Encode/Decode the sting data.
PEP352 removed backwards compatibility for indexing of BaseException. Now one needs to use args member get item based on index.
os.write method requires bytes instead of str. Fix it.
The current implementation of formatResult method for file type is broken. Add TODO to formalize api and documentation Fix it.
- ensure script is run in python 2 - use dbm instead of dumbdb
PEP352 removed backwards compatibility for indexing of BaseException. Now one needs to use args member get item based on index.py3: user Exception
Macrobutton editors are text editors (QLineEdit) and requires strings. Macro parameter default values can be however of different types e.g. int, float. Cast them all to strings.
ndbm backend does not work correctly in the way Sardana uses shelve. This backedn does not store data on disk when process receives SIGKILL or SIGABRT. gnu and dumb however works much better.
ndbm backend does not work correctly in the way Sardana uses shelve. This backend does not store data on disk when process receives SIGKILL or SIGABRT. gnu and dumb however works much better. Add MS_ENV_SHELVE_BACKEND to sardanacustomseetings in order to select between gnu and dumb backends. In case it is not specified, first try to use gnu and if not available use dumb.
Sardana requires taurus-org/taurus#960 (JSON and UTF-8 coding). Bump taurus requirement to > 4.5.4.
What do you think if we consider that the Debian 9 tests are enough? And we test both CentOS 7 and Windows ASAP but already after integrating this PR? Could you please express your opinions, especially @sardana-org/integrators ? This is a summary of issues of high importance that we need to have in mind:
There are also some technical debts that we took already and we need to pay ASAP:
|
Hi @reszelaz, many thanks for all this work, I agree with you that it can be integrated. |
Make online scan work with pyqtgraph
Allow str record data in NXscanH5_FileRecorder.
As agreed in today's sardana follow-up meeting, this PR is ready to be merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates Sardana from Python 2 to Python 3.
Sardana version gets bumped to 3.0.0 alpha.
From now on Sardana requires at least:
Taurus 4.5Taurus 4.5.5aMacroServer environment created with Python 2 needs to be manually migrated to Python 3.
Pleas use the
scripts/upgrade/upgrade_env.py
script to do so.In the migration process we found a serious problem with the Taurus and PyTango, more details in: tango-controls/pytango#292.
Whenever this issue gets clarified we will need to revert 2f0a36a.
Also whenever taurus-org/taurus#945 gets clarified we will need to adapt usage of JSONCodec (related to 25dce83).This is already done.I take a profit of this message to ask @sardana-org/integrators and anyone else interested in helping to test this PR. Whenever you find an issue with this branch please report it starting the issue summary with "Py3: ". If you have any question about the migration either comment on #1089 or open a dedicated issue for that.
Before integration we need to perform the release manual tests. I will try to extend the manual test scenarios to cover more features which are not tested automatically.
We plan to test the following platforms:
The
reszelaz/sardana-test:py3
docker image or the following conda environment can serve as inspiration for preparing the testing environment:Many thanks in advance for help in the migration process!
Fixes #1089.