Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patched archive/zip, replace with klauspost's #12

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

saracen
Copy link
Owner

@saracen saracen commented Jun 7, 2020

klauspost kindly implemented the CreateHeaderRaw proposal (golang/go#34974) in klauspost/compress#214. This repository was vendoring
the patched version (https://go-review.googlesource.com/c/go/+/202217/) but having it supported in a well maintained library already used by fastzip is a plus.

klauspost kindly implemented the CreateHeaderRaw proposal
(golang/go#34974) in
klauspost/compress#214. This repository was vendoring
the patched version (https://go-review.googlesource.com/c/go/+/202217/)
but having it supported in a well maintained library already used by fastzip is
a plus.
@codecov-commenter
Copy link

Codecov Report

Merging #12 into master will decrease coverage by 1.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   76.47%   74.47%   -2.00%     
==========================================
  Files           9       11       +2     
  Lines         493      619     +126     
==========================================
+ Hits          377      461      +84     
- Misses         70      113      +43     
+ Partials       46       45       -1     
Impacted Files Coverage Δ
archiver.go 78.17% <ø> (-1.96%) ⬇️
archiver_unix.go 100.00% <ø> (ø)
archiver_windows.go 100.00% <ø> (ø)
extractor.go 60.00% <ø> (-3.58%) ⬇️
internal/filepool/filepool.go 79.06% <0.00%> (-2.02%) ⬇️
util.go 80.00% <0.00%> (-1.82%) ⬇️
register.go 73.33% <0.00%> (-0.26%) ⬇️
archiver_options.go 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5211bf...957ab96. Read the comment docs.

@saracen saracen merged commit 1629613 into master Jun 7, 2020
@saracen saracen deleted the klauspost-zip branch June 7, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants