Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tr spend_info lock #4

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fix tr spend_info lock #4

merged 1 commit into from
Feb 8, 2022

Conversation

nickfarrow
Copy link

@nickfarrow nickfarrow commented Feb 8, 2022 •
edited
Loading

Reading cacheif let causes this function to hang. An attempt at fixing with help from @LLFourn

  • Read cache prior to matching on spend_info Option
  • added test tr_script_pubkey

@nickfarrow
Fix tr spend_info lock
855aa84 
* Attempt to read cache prior to matching on spend_info Option
* This bug would cause function to hang
* Also added test tr_script_pubkey
@nickfarrow nickfarrow mentioned this pull request Feb 8, 2022
Merged
sanket1729
sanket1729 approved these changes Feb 8, 2022
View reviewed changes
Copy link
Owner

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@sanket1729 sanket1729 merged commit 97bab62 into sanket1729:tr_descriptor Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanket1729 sanket1729 sanket1729 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickfarrow @sanket1729