Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presentation): remove explicit check for r in perspectives #8468

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Jan 31, 2025

Description

Initially we decided that releases ids will be required to start with r , this is no longer true, so this removes that explicit check from presentation and uses the selectedReleaseId to determine if we are viewing a release
It also removes the client side validations applied in core

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner January 31, 2025 15:25
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 3:43pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 3:43pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 3:43pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 3:43pm
test-next-studio ⬜️ Ignored (Inspect) Jan 31, 2025 3:43pm

Copy link
Contributor

No changes to documentation

@pedrobonamin pedrobonamin requested a review from a team as a code owner January 31, 2025 15:35
@pedrobonamin pedrobonamin requested review from ryanbonial and removed request for a team January 31, 2025 15:35
@pedrobonamin pedrobonamin changed the title fix(presentation): remove explicit check for 'r' in perspective fix(presentation): remove explicit check for r in perspectives Jan 31, 2025
@pedrobonamin pedrobonamin requested review from bjoerge and removed request for a team and ryanbonial January 31, 2025 15:36
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Component Testing Report Updated Jan 31, 2025 3:46 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 20s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 32s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 3s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Jan 31, 2025

⚡️ Editor Performance Report

Updated Fri, 31 Jan 2025 15:49:05 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 26.3 efps (38ms) 25.0 efps (40ms) +2ms (+5.3%)
article (body) 67.1 efps (15ms) 73.0 efps (14ms) -1ms (-/-%)
article (string inside object) 27.0 efps (37ms) 26.3 efps (38ms) +1ms (+2.7%)
article (string inside array) 25.6 efps (39ms) 24.4 efps (41ms) +2ms (+5.1%)
recipe (name) 50.0 efps (20ms) 47.6 efps (21ms) +1ms (+5.0%)
recipe (description) 55.6 efps (18ms) 55.6 efps (18ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 18.5 efps (54ms) 18.5 efps (54ms) +0ms (-/-%)
synthetic (string inside object) 18.9 efps (53ms) 19.6 efps (51ms) -2ms (-3.8%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 40ms 60ms 340ms 186ms 9.5s
article (body) 15ms 19ms 49ms 212ms 286ms 5.4s
article (string inside object) 37ms 41ms 45ms 147ms 256ms 6.6s
article (string inside array) 39ms 41ms 44ms 149ms 121ms 6.7s
recipe (name) 20ms 22ms 24ms 58ms 0ms 7.2s
recipe (description) 18ms 18ms 23ms 38ms 0ms 4.7s
recipe (instructions) 5ms 7ms 8ms 27ms 0ms 3.0s
synthetic (title) 54ms 55ms 61ms 297ms 795ms 12.4s
synthetic (string inside object) 53ms 58ms 68ms 511ms 1263ms 8.4s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 43ms 66ms 421ms 285ms 10.4s
article (body) 14ms 16ms 20ms 129ms 167ms 4.8s
article (string inside object) 38ms 39ms 57ms 178ms 290ms 7.1s
article (string inside array) 41ms 43ms 46ms 150ms 132ms 6.6s
recipe (name) 21ms 22ms 29ms 46ms 2ms 7.0s
recipe (description) 18ms 20ms 22ms 29ms 0ms 4.6s
recipe (instructions) 5ms 7ms 8ms 20ms 0ms 3.1s
synthetic (title) 54ms 56ms 61ms 340ms 1004ms 12.9s
synthetic (string inside object) 51ms 53ms 57ms 276ms 682ms 8.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants