You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially we decided that releases ids will be required to start with r , this is no longer true, so this removes that explicit check from presentation and uses the selectedReleaseId to determine if we are viewing a release
It also removes the client side validations applied in core
pedrobonamin
changed the title
fix(presentation): remove explicit check for 'r' in perspective
fix(presentation): remove explicit check for r in perspectives
Jan 31, 2025
efps — editor "frames per second". The number of updates assumed to be possible within a second.
Derived from input latency. efps = 1000 / input_latency
Detailed information
🏠 Reference result
The performance result of sanity@latest
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
38ms
40ms
60ms
340ms
186ms
9.5s
article (body)
15ms
19ms
49ms
212ms
286ms
5.4s
article (string inside object)
37ms
41ms
45ms
147ms
256ms
6.6s
article (string inside array)
39ms
41ms
44ms
149ms
121ms
6.7s
recipe (name)
20ms
22ms
24ms
58ms
0ms
7.2s
recipe (description)
18ms
18ms
23ms
38ms
0ms
4.7s
recipe (instructions)
5ms
7ms
8ms
27ms
0ms
3.0s
synthetic (title)
54ms
55ms
61ms
297ms
795ms
12.4s
synthetic (string inside object)
53ms
58ms
68ms
511ms
1263ms
8.4s
🧪 Experiment result
The performance result of this branch
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
40ms
43ms
66ms
421ms
285ms
10.4s
article (body)
14ms
16ms
20ms
129ms
167ms
4.8s
article (string inside object)
38ms
39ms
57ms
178ms
290ms
7.1s
article (string inside array)
41ms
43ms
46ms
150ms
132ms
6.6s
recipe (name)
21ms
22ms
29ms
46ms
2ms
7.0s
recipe (description)
18ms
20ms
22ms
29ms
0ms
4.6s
recipe (instructions)
5ms
7ms
8ms
20ms
0ms
3.1s
synthetic (title)
54ms
56ms
61ms
340ms
1004ms
12.9s
synthetic (string inside object)
51ms
53ms
57ms
276ms
682ms
8.6s
📚 Glossary
column definitions
benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
test duration — how long the test run took to complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initially we decided that releases ids will be required to start with
r
, this is no longer true, so this removes that explicit check frompresentation
and uses theselectedReleaseId
to determine if we are viewing a releaseIt also removes the client side validations applied in
core
What to review
Testing
Notes for release