Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolving dateTime picker bugs with content releases #8455

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Jan 30, 2025

Description

Cherrypick of #8403

What to review

Testing

Notes for release

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 2:05pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 2:05pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 2:05pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 2:05pm
test-next-studio ⬜️ Ignored (Inspect) Jan 30, 2025 2:05pm

@jordanl17 jordanl17 marked this pull request as ready for review January 30, 2025 13:57
@jordanl17 jordanl17 requested a review from a team as a code owner January 30, 2025 13:57
@jordanl17 jordanl17 requested review from ricokahler and removed request for a team and ricokahler January 30, 2025 13:57
Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Jan 30, 2025 2:08 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 13s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 21s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 33s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 4s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 45s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Thu, 30 Jan 2025 14:13:26 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 22.2 efps (45ms) 20.2 efps (50ms) +5ms (+10.0%)
article (body) 59.5 efps (17ms) 63.1 efps (16ms) -1ms (-5.7%)
article (string inside object) 23.8 efps (42ms) 22.7 efps (44ms) +2ms (+4.8%)
article (string inside array) 21.3 efps (47ms) 20.8 efps (48ms) +1ms (+2.1%)
recipe (name) 50.0 efps (20ms) 50.0 efps (20ms) +0ms (-/-%)
recipe (description) 52.6 efps (19ms) 55.6 efps (18ms) -1ms (-5.3%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 19.2 efps (52ms) 19.2 efps (52ms) +0ms (-/-%)
synthetic (string inside object) 20.0 efps (50ms) 19.2 efps (52ms) +2ms (+4.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 45ms 79ms 95ms 577ms 1208ms 12.3s
article (body) 17ms 21ms 37ms 171ms 212ms 6.0s
article (string inside object) 42ms 46ms 55ms 99ms 367ms 7.4s
article (string inside array) 47ms 50ms 56ms 215ms 433ms 7.6s
recipe (name) 20ms 23ms 26ms 40ms 0ms 6.9s
recipe (description) 19ms 21ms 30ms 51ms 0ms 4.7s
recipe (instructions) 5ms 7ms 8ms 17ms 0ms 3.0s
synthetic (title) 52ms 55ms 60ms 289ms 1012ms 12.5s
synthetic (string inside object) 50ms 54ms 64ms 257ms 715ms 8.6s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 50ms 74ms 85ms 514ms 1155ms 12.8s
article (body) 16ms 18ms 25ms 143ms 546ms 6.0s
article (string inside object) 44ms 46ms 49ms 62ms 259ms 7.6s
article (string inside array) 48ms 52ms 57ms 87ms 527ms 7.9s
recipe (name) 20ms 22ms 23ms 24ms 0ms 7.3s
recipe (description) 18ms 19ms 23ms 31ms 0ms 4.5s
recipe (instructions) 5ms 6ms 8ms 17ms 0ms 3.1s
synthetic (title) 52ms 56ms 68ms 436ms 1172ms 15.9s
synthetic (string inside object) 52ms 56ms 58ms 462ms 1087ms 8.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants