fix: release dateTime picker bugs #8403
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| import {EarthGlobeIcon} from '@sanity/icons' | ||
| import {Flex} from '@sanity/ui' | ||
| import {format, isValid, parse} from 'date-fns' | ||
| import {useCallback, useMemo} from 'react' | ||
|
|
||
| import {Button} from '../../../ui-components/button' | ||
| import {MONTH_PICKER_VARIANT} from '../../components/inputs/DateInputs/calendar/Calendar' | ||
| import {type CalendarLabels} from '../../components/inputs/DateInputs/calendar/types' | ||
| import {DateTimeInput} from '../../components/inputs/DateInputs/DateTimeInput' | ||
| import {getCalendarLabels} from '../../form/inputs/DateInputs' | ||
| import {useTranslation} from '../../i18n/hooks/useTranslation' | ||
| import useDialogTimeZone from '../../scheduledPublishing/hooks/useDialogTimeZone' | ||
| import useTimeZone from '../../scheduledPublishing/hooks/useTimeZone' | ||
|
|
||
| interface ScheduleDatePickerProps { | ||
| initialValue: Date | ||
| onChange: (date: Date) => void | ||
| } | ||
|
|
||
| const inputDateFormat = 'PP HH:mm' | ||
|
|
||
| export const ScheduleDatePicker = ({ | ||
| initialValue: inputValue, | ||
| onChange, | ||
| }: ScheduleDatePickerProps) => { | ||
| const {t} = useTranslation() | ||
| const {timeZone} = useTimeZone() | ||
| const {dialogTimeZoneShow} = useDialogTimeZone() | ||
|
|
||
| const handlePublishAtCalendarChange = (date: Date | null) => { | ||
| if (!date) return | ||
|
|
||
| onChange(date) | ||
| } | ||
|
|
||
| const handlePublishAtInputChange = useCallback( | ||
| (event: React.FocusEvent<HTMLInputElement>) => { | ||
| const date = event.currentTarget.value | ||
| const parsedDate = parse(date, inputDateFormat, new Date()) | ||
|
|
||
| if (isValid(parsedDate)) onChange(parsedDate) | ||
| }, | ||
| [onChange], | ||
| ) | ||
|
|
||
| const calendarLabels: CalendarLabels = useMemo(() => getCalendarLabels(t), [t]) | ||
|
|
||
| return ( | ||
| <Flex flex={1} justify="space-between"> | ||
| <DateTimeInput | ||
| selectTime | ||
| monthPickerVariant={MONTH_PICKER_VARIANT.carousel} | ||
| onChange={handlePublishAtCalendarChange} | ||
| onInputChange={handlePublishAtInputChange} | ||
| calendarLabels={calendarLabels} | ||
| value={inputValue} | ||
| inputValue={format(inputValue, inputDateFormat)} | ||
| constrainSize={false} | ||
| padding={0} | ||
| isPastDisabled | ||
| /> | ||
|
|
||
| <Button | ||
| icon={EarthGlobeIcon} | ||
| mode="bleed" | ||
| size="default" | ||
| text={`${timeZone.abbreviation}`} | ||
| onClick={dialogTimeZoneShow} | ||
| /> | ||
| </Flex> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this was something new I learned doing this:
This is I think symptomatic that the sanity UI Popover should accept a react ref as
referenceElementrather than a HTML element.But by putting this into state and setting in the
useEffect, it's ensured that the updates to thereferenceElementhappen after the initial render cycle, so that theref.currentvalue is accurate and aligned with the react state modelThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, might need to add a task to improve this at some, it just feels bad that we need to add a useeffect where the only thing we are doing is this. Which might be fine but since useEffects tend to tank performance I'm aways just 👁️ when I see them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Speaking with Jordan, we should create a story for updating the popover to work as intended instead of having us rely on workarounds from the studio side. This fine for now we adding a code comment there.