Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): reference to drafts not showing values #8393

Open
wants to merge 1 commit into
base: corel
Choose a base branch
from

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Jan 23, 2025

Description

References to documents that are only drafts are not showing in the corel branch.
This is because the getReferenceInfo function is returning an incorrect value, instead of the actual DocumentPreview is returning an object containing {snapshot: DocumentPreview, type: string}

This PR changes that and fixes the preview.
See for example in this page:

Corel Fixed
Screenshot 2025-01-23 at 18 31 07 Screenshot 2025-01-23 at 18 31 12

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner January 23, 2025 17:32
@pedrobonamin pedrobonamin requested review from ricokahler and removed request for a team January 23, 2025 17:32
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 5:36pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 5:36pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 5:36pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jan 23, 2025 5:36pm
test-next-studio ⬜️ Ignored (Inspect) Jan 23, 2025 5:36pm

@pedrobonamin pedrobonamin requested review from juice49 and a team and removed request for ricokahler January 23, 2025 17:33
Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Jan 23, 2025 5:40 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 20s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 46s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 2s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Thu, 23 Jan 2025 17:45:01 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 24.4 efps (41ms) 24.4 efps (41ms) +0ms (-/-%)
article (body) 63.3 efps (16ms) 67.3 efps (15ms) -1ms (-/-%)
article (string inside object) 25.3 efps (40ms) 28.6 efps (35ms) -5ms (-11.4%)
article (string inside array) 22.2 efps (45ms) 24.7 efps (41ms) -5ms (-10.0%)
recipe (name) 50.0 efps (20ms) 62.5 efps (16ms) -4ms (-20.0%)
recipe (description) 55.6 efps (18ms) 62.5 efps (16ms) -2ms (-11.1%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (5ms) -1ms (-/-%)
synthetic (title) 18.9 efps (53ms) 20.4 efps (49ms) -4ms (-7.5%)
synthetic (string inside object) 19.6 efps (51ms) 20.0 efps (50ms) -1ms (-2.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 44ms 51ms 465ms 283ms 12.7s
article (body) 16ms 17ms 30ms 170ms 248ms 5.5s
article (string inside object) 40ms 44ms 51ms 80ms 300ms 7.1s
article (string inside array) 45ms 47ms 50ms 163ms 222ms 7.1s
recipe (name) 20ms 21ms 25ms 38ms 0ms 7.0s
recipe (description) 18ms 20ms 23ms 38ms 0ms 4.4s
recipe (instructions) 6ms 7ms 8ms 9ms 0ms 3.1s
synthetic (title) 53ms 56ms 68ms 363ms 1152ms 12.7s
synthetic (string inside object) 51ms 54ms 62ms 228ms 427ms 8.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 59ms 65ms 505ms 786ms 11.0s
article (body) 15ms 17ms 22ms 164ms 226ms 5.6s
article (string inside object) 35ms 37ms 45ms 172ms 137ms 7.0s
article (string inside array) 41ms 44ms 52ms 151ms 159ms 6.9s
recipe (name) 16ms 18ms 20ms 31ms 0ms 7.1s
recipe (description) 16ms 17ms 19ms 26ms 0ms 4.4s
recipe (instructions) 5ms 6ms 8ms 16ms 0ms 3.1s
synthetic (title) 49ms 53ms 67ms 336ms 851ms 11.9s
synthetic (string inside object) 50ms 53ms 58ms 155ms 1156ms 8.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant