Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): support searching references in same release [WIP] #8392

Open
wants to merge 2 commits into
base: corel
Choose a base branch
from

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Jan 23, 2025

Description

When searching to add a reference in a document, documents that are available in the same release should show.

Screen.Recording.2025-01-23.at.20.00.39.mov

What to review

Testing

Manual testing for now:

  • Create a document in a release.
  • Go to a document that could reference the previously created document.
  • The document should show in the list.

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner January 23, 2025 16:58
@pedrobonamin pedrobonamin requested review from jordanl17 and removed request for a team January 23, 2025 16:58
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 7:06pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 7:06pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 7:06pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 7:06pm
test-next-studio ⬜️ Ignored (Inspect) Jan 23, 2025 7:06pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Component Testing Report Updated Jan 23, 2025 7:09 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 21s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 32s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 4s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 45s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Jan 23, 2025

⚡️ Editor Performance Report

Updated Thu, 23 Jan 2025 19:11:02 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 22.2 efps (45ms) 27.8 efps (36ms) -9ms (-20.0%)
article (body) 67.8 efps (15ms) 72.5 efps (14ms) -1ms (-/-%)
article (string inside object) 25.6 efps (39ms) 29.4 efps (34ms) -5ms (-12.8%)
article (string inside array) 21.1 efps (48ms) 24.7 efps (41ms) -7ms (-14.7%)
recipe (name) 52.6 efps (19ms) 62.5 efps (16ms) -3ms (-15.8%)
recipe (description) 58.8 efps (17ms) 66.7 efps (15ms) -2ms (-11.8%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (5ms) -1ms (-/-%)
synthetic (title) 19.4 efps (52ms) 20.4 efps (49ms) -3ms (-4.9%)
synthetic (string inside object) 19.8 efps (51ms) 20.0 efps (50ms) -1ms (-1.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 45ms 65ms 70ms 511ms 966ms 11.3s
article (body) 15ms 18ms 20ms 38ms 216ms 5.3s
article (string inside object) 39ms 41ms 49ms 160ms 139ms 7.0s
article (string inside array) 48ms 50ms 58ms 119ms 313ms 7.4s
recipe (name) 19ms 21ms 28ms 41ms 0ms 7.2s
recipe (description) 17ms 18ms 20ms 36ms 0ms 4.4s
recipe (instructions) 6ms 8ms 9ms 24ms 0ms 3.4s
synthetic (title) 52ms 57ms 65ms 332ms 800ms 12.9s
synthetic (string inside object) 51ms 58ms 68ms 150ms 1090ms 8.4s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 36ms 56ms 62ms 377ms 625ms 10.7s
article (body) 14ms 15ms 18ms 140ms 189ms 5.0s
article (string inside object) 34ms 38ms 59ms 160ms 153ms 6.7s
article (string inside array) 41ms 42ms 45ms 83ms 59ms 6.8s
recipe (name) 16ms 17ms 21ms 40ms 0ms 6.6s
recipe (description) 15ms 16ms 17ms 29ms 0ms 4.4s
recipe (instructions) 5ms 7ms 8ms 17ms 0ms 3.1s
synthetic (title) 49ms 58ms 91ms 412ms 1541ms 15.5s
synthetic (string inside object) 50ms 53ms 68ms 567ms 1376ms 8.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin pedrobonamin marked this pull request as draft January 23, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant